<p> Attention is currently required from: Kevin Harwell. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/17720">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/tcptls.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17720/comment/7e5954b3_6981f6b8">Patch Set #2, Line 167:</a> <code style="font-family:monospace,monospace">  * \brief Attempt to connect, and start a tcptls session within the given timeout</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think the comma is needed</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17720/comment/44dffd87_3b7cbbfe">Patch Set #2, Line 169:</a> <code style="font-family:monospace,monospace">  * Note, on error the tcptls_session's ref count is decremented,* fd and file</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use \note here? You also have an errant * after 'decremented.'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17720/comment/ebba92bc_b66e196b">Patch Set #2, Line 181:</a> <code style="font-family:monospace,monospace">  * \brief Attempt to connect, and start a tcptls session</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think the comma is needed</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17720/comment/3037d607_6b158f80">Patch Set #2, Line 185:</a> <code style="font-family:monospace,monospace">  * Note, on error the tcptls_session's ref count is decremented,* fd and file</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use \note here? You also have an errant * after 'decremented.'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/tcptls.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17720/comment/7026e829_9f5d885f">Patch Set #2, Line 663:</a> <code style="font-family:monospace,monospace">    ast_fd_clear_flags(desc->accept_fd, O_NONBLOCK);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Potentially dumb question, but: Why are we clearing O_NONBLOCK here but...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17720/comment/fca076ea_8cf6032f">Patch Set #2, Line 692:</a> <code style="font-family:monospace,monospace">        fd = desc->accept_fd = ast_socket_nonblock(ast_sockaddr_is_ipv6(&desc->remote_address) ?</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">... explicitly asking for it here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17720">change 17720</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17720"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I907571843a83e43c0742b95a64785f4411f02671 </div>
<div style="display:none"> Gerrit-Change-Number: 17720 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Dec 2021 21:29:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>