[Asterisk-code-review] progdocs: Update Makefile. (asterisk[16])

Alexander Traud asteriskteam at digium.com
Tue Dec 7 03:15:53 CST 2021


Attention is currently required from: George Joseph.
Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17578 )

Change subject: progdocs: Update Makefile.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> > The problem with the doxygen.log, you must know that it is there. […]
So, you want to see the warnings. And your suggestion is to bring back doxygen.log. I have to understand that first. That is the reason for the -1. And that is your suggestion to solve the -1. Correct? What do you mean with Wiki, update the Wiki about make progdocs and add there that a doxygen.log is generated?

I fixed this issue in around a dozen projects, and none of them worked with a logfile, some even bigger (and with much more output in Doxygen) then Asterisk. You do not even have to save/pipe the output, just search. Anyway, what about my approach
a) bring back doxygen.log and place an echo in the Makefile that there is a doxygen.log?
or
b) now that we have zero warnings (right now), what about error on first warning b1) in Developer Mode b2) in general?
or
c) filter the output of Doxygen via the Makefile via your proposed sed and display that.

Or a combination of those?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17578
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4129092a199d5e24c319a09cd088614b121015af
Gerrit-Change-Number: 17578
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 07 Dec 2021 09:15:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Alexander Traud <pabstraud at compuserve.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211207/19ca1e46/attachment.html>


More information about the asterisk-code-review mailing list