[Asterisk-code-review] progdocs: Update Makefile. (asterisk[16])

George Joseph asteriskteam at digium.com
Mon Dec 6 11:14:04 CST 2021


Attention is currently required from: Alexander Traud.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17578 )

Change subject: progdocs: Update Makefile.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> The problem with the doxygen.log, you must know that it is there. Without an extra log, the warning at least passes the screen and you can grep through the results, simply fro ‘: warning:’.

I can't imagine anyone manually saving the output and grepping for warnings. :)  With the log, it at least only contained the warnings and we can update the wiki and send an email to the asterisk-dev list asking for folks to run 'make progdocs' and check the log.

> I look into that noisy thing. I tested it only once with --enable-dev-mode=noisy.

You don't have to.  The issue was that I was only piping stdout to tee so none of the warnings were being set to my log.  That's another reason to bring back the doxygen.log file.

> > suppress all the "Generating docs for" messages
> 
> I do not understand that. Are those new and you want me to suppress them as well or do you mean those message make happen anyway and therefore it difficult to find the warnings?

The latter.  The warnings get lost with all the other output.  If you pipe the output through 'sed -r -e "/(Reading|Searching|Parsing|Preprocessing|(Generating (docs|code)))/d"' we'll see the major progress messages and the warnings.  That will increase the odds of someone actually looking at the warnings even further.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17578
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4129092a199d5e24c319a09cd088614b121015af
Gerrit-Change-Number: 17578
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Mon, 06 Dec 2021 17:14:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Alexander Traud <pabstraud at compuserve.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211206/7523f6a1/attachment.html>


More information about the asterisk-code-review mailing list