[Asterisk-code-review] app_mf: Add full tech-agnostic MF support (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16499 )

Change subject: app_mf: Add full tech-agnostic MF support
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

File apps/app_mf.c:

https://gerrit.asterisk.org/c/asterisk/+/16499/comment/ae23fd10_2aba3758 
PS2, Line 243: 				break;
This path leaks frame. Use ast_frfree to free it.


https://gerrit.asterisk.org/c/asterisk/+/16499/comment/db5496ac_ec3ef95d 
PS2, Line 253: 						continue;
This path leaks frame too.


https://gerrit.asterisk.org/c/asterisk/+/16499/comment/e63c0abf_1f79dbac 
PS2, Line 268: 							continue;
frame is leaked here as well.


https://gerrit.asterisk.org/c/asterisk/+/16499/comment/7f155bb7_a005b00e 
PS2, Line 276: 						*str++ = result;
I think to be safe this needs to check some upper bound so the passed in buf is not potentially written past the end of designated memory.

If you can guarantee that will never happen then I think at least a comment stating as such is warranted.


https://gerrit.asterisk.org/c/asterisk/+/16499/comment/8a9516a6_a01d9a2e 
PS2, Line 282: 						break;
frame leaked here too.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16499
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I61962b359b8ec4cfd05df877ddf9f5b8f71927a4
Gerrit-Change-Number: 16499
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 03 Dec 2021 21:16:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211203/b8c2a745/attachment.html>