<p> Attention is currently required from: N A, George Joseph. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16499">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_mf.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16499/comment/ae23fd10_2aba3758">Patch Set #2, Line 243:</a> <code style="font-family:monospace,monospace">                           break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This path leaks frame. Use ast_frfree to free it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16499/comment/db5496ac_ec3ef95d">Patch Set #2, Line 253:</a> <code style="font-family:monospace,monospace">                                              continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This path leaks frame too.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16499/comment/e63c0abf_1f79dbac">Patch Set #2, Line 268:</a> <code style="font-family:monospace,monospace">                                                  continue;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">frame is leaked here as well.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16499/comment/7f155bb7_a005b00e">Patch Set #2, Line 276:</a> <code style="font-family:monospace,monospace">                                               *str++ = result;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think to be safe this needs to check some upper bound so the passed in buf is not potentially written past the end of designated memory.</p><p style="white-space: pre-wrap; word-wrap: break-word;">If you can guarantee that will never happen then I think at least a comment stating as such is warranted.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16499/comment/8a9516a6_a01d9a2e">Patch Set #2, Line 282:</a> <code style="font-family:monospace,monospace">                                               break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">frame leaked here too.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16499">change 16499</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16499"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I61962b359b8ec4cfd05df877ddf9f5b8f71927a4 </div>
<div style="display:none"> Gerrit-Change-Number: 16499 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 03 Dec 2021 21:16:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>