[Asterisk-code-review] pbx_ael: Fix possible crash and serious lockup issue regarding 'ael ... (asterisk[master])

[Mark Murawski]

Mark Murawski has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/16350 )


Change subject: pbx_ael:  Fix possible crash and serious lockup issue regarding 'ael reload'
......................................................................

pbx_ael:  Fix possible crash and serious lockup issue regarding 'ael reload'

Currently pbx_ael does not check if a reload is currently pending
before proceeding with a reload. This can cause multiple threads to
operate at the same time on what should be mutex protected data.  This
change adds a reload mutex and prevents multiple reloads from occuring
simultaneously.

ASTERISK-29609 #close

Change-Id: Ieb3b5c35fd564d84d05d6e7ea9255f792d81c35a
---
M pbx/pbx_ael.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/50/16350/1

diff --git a/pbx/pbx_ael.c b/pbx/pbx_ael.c
index d55f2d4..28242f3 100644
--- a/pbx/pbx_ael.c
+++ b/pbx/pbx_ael.c
@@ -245,7 +245,7 @@
 	if (a->argc != 2)
 		return CLI_SHOWUSAGE;
 
-	return (pbx_load_module() ? CLI_FAILURE : CLI_SUCCESS);
+	return ast_module_reload("pbx_ael") == AST_MODULE_RELOAD_SUCCESS ? CLI_SUCCESS : CLI_FAILURE;
 }
 
 static struct ast_cli_entry cli_ael[] = {

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16350
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ieb3b5c35fd564d84d05d6e7ea9255f792d81c35a
Gerrit-Change-Number: 16350
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/6fa99269/attachment-0001.html>