[Asterisk-code-review] pbx_ael: Fix possible crash and serious lockup issue regarding 'ael ... (asterisk[master])

Sean Bright asteriskteam at digium.com
Tue Aug 24 13:36:26 CDT 2021


Attention is currently required from: Mark Murawski.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16348 )

Change subject: pbx_ael:  Fix possible crash and serious lockup issue regarding 'ael reload'
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File pbx/pbx_ael.c:

https://gerrit.asterisk.org/c/asterisk/+/16348/comment/2448d085_8ff8f738 
PS1, Line 327: 	return (pbx_load_module_from_cli_locked(a) ? CLI_FAILURE : CLI_SUCCESS);
This is the only thing required. We do something similar in res_musiconhold to prevent simultaneous reloads:

 return ast_module_reload("pbx_ael") == AST_MODULE_RELOAD_SUCCESS ? CLI_SUCCESS : CLI_FAILURE;



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16348
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5ed392ad226f6e4e7696ad742076d3e45c57af35
Gerrit-Change-Number: 16348
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Tue, 24 Aug 2021 18:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/8429b9c5/attachment.html>


More information about the asterisk-code-review mailing list