[Asterisk-code-review] app_milliwatt: Timing fix (asterisk[master])

Sean Bright asteriskteam at digium.com
Fri Aug 13 09:33:09 CDT 2021


Attention is currently required from: N A, Joshua Colp.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16238 )

Change subject: app_milliwatt: Timing fix
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

Patchset:

PS4: 
One more minor cleanup while you're in there. Otherwise this looks good to me.


File apps/app_milliwatt.c:

https://gerrit.asterisk.org/c/asterisk/+/16238/comment/e580f7d6_d98a8eb3 
PS4, Line 43: 1004Hz
Can you make the spacing before 'Hz' consistent in this documentation? I know you didn't change this occurrence but this XML block contains some with spaces and some without. I'll defer to you as to which one is more technically correct.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16238
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I73ccc6c6fcaa31931c6fff3b85ad1805b2ce9d8c
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 14:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210813/d6c58d53/attachment.html>


More information about the asterisk-code-review mailing list