[Asterisk-code-review] app_milliwatt: Timing fix (asterisk[master])

N A asteriskteam at digium.com
Fri Aug 13 09:30:53 CDT 2021


Attention is currently required from: Sean Bright, Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16238 )

Change subject: app_milliwatt: Timing fix
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> Everyone I discuss the Milliwatt() application with likes its current behavior, so it seems that the […]
Like I said... it was already broken. I don't know what you other folks are doing with it but it is most certainly not using it for a milliwatt test.

But fine, whatever, I don't want to get into a drawn out discussion about this and it sounds like there are compatibility concerns. I've changed it so that a configurable option is used to enable the correct behavior (default is unchanged). Also made it clear that this option needs to be enabled to make the app work properly, since people calling Milliwatt() will continue to get the wrong behavior.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16238
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I73ccc6c6fcaa31931c6fff3b85ad1805b2ce9d8c
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 14:30:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210813/ebf94e5f/attachment.html>


More information about the asterisk-code-review mailing list