[Asterisk-code-review] app_dial: Prevent call from hanging (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15985 )

Change subject: app_dial: Prevent call from hanging
......................................................................


Patch Set 2:

(1 comment)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15985/comment/4f1ac9da_34005ded 
PS2, Line 1802: 						if (ast_check_hangup_locked(o->chan)) {
> All right, did debugging in ast_read and then app_dial again and... […]
And with that, I believe I may have located the issue:

This is executing every infinite loop:
https://github.com/asterisk/asterisk/blob/master/main/channel.c#L3767

That is, it's an AST_FRAME_VOICE frame, and we're calling this:
stream = default_stream = ast_channel_get_default_stream(chan, ast_format_get_type(f->subclass.format));

The description of this function is "Retrieve the default stream of a specific media type on a channel". It sounds to me like for some reason we are trying to create dummy voice frames for no particular reason.
When I print out the stream number, I get 0 every time, which fits, I guess.

Still doesn't indicate why we're doing this, but this, at least, seems to be the source of the infinite/endless supply of frames that the in channel is being forced to process.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15985
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6f2ee3f77b892015bc05513d868f071f279a3c80
Gerrit-Change-Number: 15985
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 07 Aug 2021 02:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210806/1026b01f/attachment.html>