[Asterisk-code-review] app_dial: Prevent call from hanging (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15985 )

Change subject: app_dial: Prevent call from hanging
......................................................................


Patch Set 2:

(1 comment)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15985/comment/34879c0e_8b2a4c50 
PS2, Line 1802: 						if (ast_check_hangup_locked(o->chan)) {
> It should not be necessary for app_dial to call ast_check_hangup_locked, ast_read should be called a […]
All right, did debugging in ast_read and then app_dial again and... lo and behold, it's not even DTMF frames at all:

I doubt this changes anything technical-wise, but it's not AST_FRAME_DTMF_END we're dealing with here... just plain old AST_FRAME_VOICE (which actually makes sense now - that's what func_frametrace was showing the whole time).

In the switch statement, the voice case happens to fall into the DTMF case, which is where the error is, so *that* was a conclusion jump on my part. It seemed to make sense when it was happening with DTMF-related things, but DTMF frames are definitely *not* in play here. We've got an infinite barrage of voice frames queued on the in channel, instead.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15985
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6f2ee3f77b892015bc05513d868f071f279a3c80
Gerrit-Change-Number: 15985
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 07 Aug 2021 01:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210806/9874702c/attachment-0001.html>