[Asterisk-code-review] func_lookup: Fork of HINT function (asterisk[master])

[N A]

Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_lookup: Fork of HINT function
......................................................................


Patch Set 9:

(1 comment)

File funcs/func_lookup.c:

https://gerrit.asterisk.org/c/asterisk/+/16075/comment/6a893860_84a70f37 
PS9, Line 127: /* Substitute variables now, using the location of the lookup */
             : 	/* strdupa required or we'll just overwrite what we read when we set these */
             : 	realcontext = ast_strdupa(ast_channel_context(chan));
             : 	realexten = ast_strdupa(ast_channel_exten(chan));
             : 	realpriority = ast_channel_priority(chan);
             : 	ast_channel_lock(chan);
             : 	ast_channel_context_set(chan, context);
             : 	ast_channel_exten_set(chan, exten);
             : 	ast_channel_priority_set(chan, priority);
             : 	ast_channel_unlock(chan);
             : 
> > Correct... with a slight technicality. […]
I think your idea of using these special channel variables is probably most elegant. Are you envisioning something like this?

same => n,Return(${DB(something/something)}${EXTEN_EVAL:-4})

That wouldn't require the actual EXTEN to be changed at any point. Are you just referring to the fact that this would trigger SetVar / NewVar AMI events?

By #2, do you just mean change ${EXTEN} -> ${EVAL_EXTEN} behind the scenes (which we can set in the function), and then hand it off to the substituter? That could also work, and the UX is the same to the user this way.

I can't think of needing the original EXTEN, other than passing EXTEN in as the literal EXTEN to a lookup, but if you think that would be better for some reason than #1 seems like a natural choice. Otherwise, I feel like #2 might be more intuitive, but I'm open to either approach.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 9
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 19:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/a80357df/attachment-0001.html>