<p> Attention is currently required from: George Joseph. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16075">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File funcs/func_lookup.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16075/comment/6a893860_84a70f37">Patch Set #9, Line 127:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* Substitute variables now, using the location of the lookup */<br> /* strdupa required or we'll just overwrite what we read when we set these */<br>     realcontext = ast_strdupa(ast_channel_context(chan));<br> realexten = ast_strdupa(ast_channel_exten(chan));<br>     realpriority = ast_channel_priority(chan);<br>    ast_channel_lock(chan);<br>       ast_channel_context_set(chan, context);<br>       ast_channel_exten_set(chan, exten);<br>   ast_channel_priority_set(chan, priority);<br>     ast_channel_unlock(chan);<br><br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">> Correct... with a slight technicality. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think your idea of using these special channel variables is probably most elegant. Are you envisioning something like this?</p><p style="white-space: pre-wrap; word-wrap: break-word;">same => n,Return(${DB(something/something)}${EXTEN_EVAL:-4})</p><p style="white-space: pre-wrap; word-wrap: break-word;">That wouldn't require the actual EXTEN to be changed at any point. Are you just referring to the fact that this would trigger SetVar / NewVar AMI events?</p><p style="white-space: pre-wrap; word-wrap: break-word;">By #2, do you just mean change ${EXTEN} -> ${EVAL_EXTEN} behind the scenes (which we can set in the function), and then hand it off to the substituter? That could also work, and the UX is the same to the user this way.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I can't think of needing the original EXTEN, other than passing EXTEN in as the literal EXTEN to a lookup, but if you think that would be better for some reason than #1 seems like a natural choice. Otherwise, I feel like #2 might be more intuitive, but I'm open to either approach.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16075">change 16075</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16075"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432 </div>
<div style="display:none"> Gerrit-Change-Number: 16075 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sarah Autumn <sarah@endlesstemple.org> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 05 Aug 2021 19:03:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Comment-In-Reply-To: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>