[Asterisk-code-review] app_originate: Add ability to set codecs (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16232 )

Change subject: app_originate: Add ability to set codecs
......................................................................


Patch Set 2:

(2 comments)

File apps/app_originate.c:

https://gerrit.asterisk.org/c/asterisk/+/16232/comment/20e80921_786db0c5 
PS2, Line 204: 	ast_format_cap_append(capabilities, ast_format_slin, 0);
> The change was because a) people can now specify which codecs to use, including any slin codecs, and […]
Such a change needs to be documented, I think it would be okay but it's still a substantial difference.


https://gerrit.asterisk.org/c/asterisk/+/16232/comment/13026a3d_b06a23ed 
PS2, Line 262: 			ast_format_cap_update_by_allow_disallow(capabilities, opt_args[OPT_ARG_CODECS], 1);
> It keeps slin and appends what is allowed, since a function call only adds to or removes. […]
That's not documented at all with the option, the documentation makes it seem as though what you specify is used and slin is only used as a default if not specified.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16232
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I96a1aeb83d54b635b7a51e1b4680f03791622883
Gerrit-Change-Number: 16232
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:23:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/87ceb420/attachment.html>