[Asterisk-code-review] app_originate: Add ability to set codecs (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16232 )

Change subject: app_originate: Add ability to set codecs
......................................................................


Patch Set 2:

(2 comments)

File apps/app_originate.c:

https://gerrit.asterisk.org/c/asterisk/+/16232/comment/b428b81e_a21c5bf1 
PS2, Line 204: 	ast_format_cap_append(capabilities, ast_format_slin, 0);
> This is a behavior change to have this single codec. […]
The change was because a) people can now specify which codecs to use, including any slin codecs, and b) it seems that we have found that using Originate can consistently cause weird issues because slin192 will end up getting used, so this should "work better". In most cases, slin is desired over slin192 (at least from my assessment), so the default should be the most compatible way. This is also closer to the behavior of the Originate AMI action and call files, neither of which add all the slin's to their codec list.


https://gerrit.asterisk.org/c/asterisk/+/16232/comment/c0c87180_41a2ed94 
PS2, Line 262: 			ast_format_cap_update_by_allow_disallow(capabilities, opt_args[OPT_ARG_CODECS], 1);
> Does this keep slin in the capabilties by appending what is allowed, or does it start fresh?
It keeps slin and appends what is allowed, since a function call only adds to or removes. Another reason I kept the slin list to just slin, rather than all of them.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16232
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I96a1aeb83d54b635b7a51e1b4680f03791622883
Gerrit-Change-Number: 16232
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:20:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/6f187dce/attachment.html>