[Asterisk-code-review] loader: Sync load- and build-time deps. (asterisk[18])

Alexander Traud asteriskteam at digium.com
Mon Nov 2 09:25:29 CST 2020


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15119 )

Change subject: loader: Sync load- and build-time deps.
......................................................................


Patch Set 1:

With backtrace, do you mean the Console Output? That output, I do not understand. If you are about something else, do you have a direct link?

> remember that having weird load order requirements.

Yes, I saw your review comments on that back then before. No problems here. Perhaps a core team member can chime in and clarify.

> the res_sorcery_* modules should not be listed under `.requires`.

In that case,
a) why they are marked "depend" in MODULEINFO?
b) both res_pjsip and res_pjproject or just res_pjsip?

> The modules you've listed are needed by the default configuration, this can be changed though.

Mhm. Do you have an example which configuration file/parameter/option controls that?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15119
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I254dd33194ae38d2877b8021c57c2a5deb6bbcd2
Gerrit-Change-Number: 15119
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Mon, 02 Nov 2020 15:25:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201102/d50b5dd2/attachment-0001.html>


More information about the asterisk-code-review mailing list