[Asterisk-code-review] loader: Sync load- and build-time deps. (asterisk[18])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15119 )

Change subject: loader: Sync load- and build-time deps.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> no idea why the build fails

You can look at the backtrace files at the jenkins link given for the failure message.  This uses the same credentials as gerrit.  Looks like res_pjsip loaded in the wrong order and caused an assertion on NULL message type.  Might be related to the res_pjsip_config_wizard change, I seem to remember that having weird load order requirements.

Unrelated comment the res_sorcery_* modules should not be listed under `.requires`.  Maybe they could be listed in `.optional_modules` which would force load/unload order only if those sorcery modules are being loaded.  The modules you've listed are needed by the default configuration, this can be changed though.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15119
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I254dd33194ae38d2877b8021c57c2a5deb6bbcd2
Gerrit-Change-Number: 15119
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Mon, 02 Nov 2020 14:15:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201102/77ae357d/attachment.html>