[Asterisk-code-review] codec_gsm: Honor global optimization flags like DONT_OPTIMIZE. (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14262 )

Change subject: codec_gsm: Honor global optimization flags like DONT_OPTIMIZE.
......................................................................


Patch Set 1:

Still, I do not know what is expected from me. If you have a wording which is acceptable, please, suggest one or even take over this change.

Once again: OPTIMIZE from the top Makefile is copied always (except it is GCC 4.2). Tested here, can you confirm? Therefore, GCC is called with -Oi -O3 always. Tested here, can you confirm? Now, because of some other issue, GCC is called with -Oi -03 -0i. Tested here, can you confirm? And, yes, according the GCC documentation (and my tests) only the last -Ox is used. The latter is new to me and I am not sure if this is cross-compiler save.

Are you telling me indirectly that this third/last optimization flag is intended (not another issue) and therefore this change here cannot have anything to do with DONT_OPTIMIZE? 'The problem with the GSM codec module was that it copied the top most OPTIMIZE always (except it was GCC 4.2), regardless of the state of DONT_OPTIMIZE.' Would that be an acceptable wording for the commit message? I do not get it.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14262
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If65ffcf34045fff1c86a3d492feba222a48f3806
Gerrit-Change-Number: 14262
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 28 May 2020 10:14:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200528/fb7e0994/attachment.html>