[Asterisk-code-review] res_stir_shaken: Added dialplan function and API call. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14339 )

Change subject: res_stir_shaken: Added dialplan function and API call.
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14339/4/include/asterisk/res_stir_shaken.h 
File include/asterisk/res_stir_shaken.h:

https://gerrit.asterisk.org/c/asterisk/+/14339/4/include/asterisk/res_stir_shaken.h@24 
PS4, Line 24: enum ast_stir_shaken_verification_result;
Since ast_stir_shaken_add_verification() is a public function and it expects a value from the enum, the enum needs to be defined here, not just declared.  Otherwise no one will be able to call the function except from within res_stir_shaken.c.


https://gerrit.asterisk.org/c/asterisk/+/14339/4/res/res_stir_shaken.c 
File res/res_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/14339/4/res/res_stir_shaken.c@104 
PS4, Line 104: 	<function name="STIR_SHAKEN" language="en_US">
             : 		<synopsis>
             : 			Gets the number of STIR/SHAKEN results or a specific STIR/SHAKEN value from a result on the channel.
             : 		</synopsis>
             : 		<syntax>
             : 			<parameter name="index" required="true">
             : 				<para>The index of the STIR/SHAKEN result to get. If only 'count' is passed in, gets the number of STIR/SHAKEN results instead.</para>
             : 			</parameter>
             : 			<parameter name="value" required="false">
             : 				<para>The value to get from the STIR/SHAKEN result. Only used when an index is passed in (instead of 'count'). Allowable values:</para>
             : 				<enumlist>
             : 					<enum name = "identity" />
             : 					<enum name = "attestation" />
             : 					<enum name = "verify_result" />
             : 				</enumlist>
             : 			</parameter>
             : 		</syntax>
             : 	</function>
How about adding the sample calls you have in the commit message.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14339
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ice6d52a3a7d6e4607c9c35b28a1f7c25f5284a82
Gerrit-Change-Number: 14339
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 11 May 2020 14:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200511/51023950/attachment.html>