<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14339">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14339/4/include/asterisk/res_stir_shaken.h">File include/asterisk/res_stir_shaken.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14339/4/include/asterisk/res_stir_shaken.h@24">Patch Set #4, Line 24:</a> <code style="font-family:monospace,monospace">enum ast_stir_shaken_verification_result;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since ast_stir_shaken_add_verification() is a public function and it expects a value from the enum, the enum needs to be defined here, not just declared. Otherwise no one will be able to call the function except from within res_stir_shaken.c.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14339/4/res/res_stir_shaken.c">File res/res_stir_shaken.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14339/4/res/res_stir_shaken.c@104">Patch Set #4, Line 104:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <function name="STIR_SHAKEN" language="en_US"><br> <synopsis><br> Gets the number of STIR/SHAKEN results or a specific STIR/SHAKEN value from a result on the channel.<br> </synopsis><br> <syntax><br> <parameter name="index" required="true"><br> <para>The index of the STIR/SHAKEN result to get. If only 'count' is passed in, gets the number of STIR/SHAKEN results instead.</para><br> </parameter><br> <parameter name="value" required="false"><br> <para>The value to get from the STIR/SHAKEN result. Only used when an index is passed in (instead of 'count'). Allowable values:</para><br> <enumlist><br> <enum name = "identity" /><br> <enum name = "attestation" /><br> <enum name = "verify_result" /><br> </enumlist><br> </parameter><br> </syntax><br> </function><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about adding the sample calls you have in the commit message.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14339">change 14339</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14339"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ice6d52a3a7d6e4607c9c35b28a1f7c25f5284a82 </div>
<div style="display:none"> Gerrit-Change-Number: 14339 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 11 May 2020 14:57:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>