[Asterisk-code-review] res_stir_shaken: Added dialplan function and API call. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14339 )

Change subject: res_stir_shaken: Added dialplan function and API call.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/14339/1/res/res_stir_shaken.c 
File res/res_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/14339/1/res/res_stir_shaken.c@1108 
PS1, Line 1108: 				ast_log(LOG_NOTICE, "skip\n");
Old debug


https://gerrit.asterisk.org/c/asterisk/+/14339/1/res/res_stir_shaken.c@1123 
PS1, Line 1123: 		ast_log(LOG_ERROR, "Retrieving a value using %s requires two paramaters (index, value)\n", function);
I think this could be more user friendly, such as stating what was actually passed in


https://gerrit.asterisk.org/c/asterisk/+/14339/1/res/res_stir_shaken.c@1128 
PS1, Line 1128: 		ast_log(LOG_ERROR, "Could not convert %s to integer\n", args.first_param);
This could also be more user friendly



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14339
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ice6d52a3a7d6e4607c9c35b28a1f7c25f5284a82
Gerrit-Change-Number: 14339
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 05 May 2020 10:51:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200505/3a3dbade/attachment.html>