<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14339">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14339/1/res/res_stir_shaken.c">File res/res_stir_shaken.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14339/1/res/res_stir_shaken.c@1108">Patch Set #1, Line 1108:</a> <code style="font-family:monospace,monospace">                             ast_log(LOG_NOTICE, "skip\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Old debug</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14339/1/res/res_stir_shaken.c@1123">Patch Set #1, Line 1123:</a> <code style="font-family:monospace,monospace">                ast_log(LOG_ERROR, "Retrieving a value using %s requires two paramaters (index, value)\n", function);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this could be more user friendly, such as stating what was actually passed in</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14339/1/res/res_stir_shaken.c@1128">Patch Set #1, Line 1128:</a> <code style="font-family:monospace,monospace">             ast_log(LOG_ERROR, "Could not convert %s to integer\n", args.first_param);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This could also be more user friendly</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14339">change 14339</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14339"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ice6d52a3a7d6e4607c9c35b28a1f7c25f5284a82 </div>
<div style="display:none"> Gerrit-Change-Number: 14339 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 05 May 2020 10:51:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>