[Asterisk-code-review] manager: Add support for specifying codecs when originating. (starpy[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/starpy/+/14023 )

Change subject: manager: Add support for specifying codecs when originating.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-1
> > 
> > Since there's a test dependency on this, the starpy version should probably be bumped to 1.0.3 and the test should depend on this version.
> 
> Shouldn't the version bump be in a separate "new release" commit?  I'd assume the new release commit would get pushed directly to git with an associated git tag?

It can be. 😄


-- 
To view, visit https://gerrit.asterisk.org/c/starpy/+/14023
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: starpy
Gerrit-Branch: master
Gerrit-Change-Id: I1fd6bb125d1e2dbbdaa13a1f2177a2fb29ec287a
Gerrit-Change-Number: 14023
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 14:17:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200325/797a25c2/attachment.html>