<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">Since there's a test dependency on this, the starpy version should probably be bumped to 1.0.3 and the test should depend on this version.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't the version bump be in a separate "new release" commit?  I'd assume the new release commit would get pushed directly to git with an associated git tag?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">It can be. 😄</p><p><a href="https://gerrit.asterisk.org/c/starpy/+/14023">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/starpy/+/14023">change 14023</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/starpy/+/14023"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: starpy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1fd6bb125d1e2dbbdaa13a1f2177a2fb29ec287a </div>
<div style="display:none"> Gerrit-Change-Number: 14023 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 25 Mar 2020 14:17:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>