[Asterisk-code-review] dns_txt: Add TXT record parsing support (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13935 )

Change subject: dns_txt: Add TXT record parsing support
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_internal.h 
File include/asterisk/dns_internal.h:

https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_internal.h@29 
PS1, Line 29: /*! \brief For AST_LIST */
Where is AST_LIST used?


https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_txt.h 
File include/asterisk/dns_txt.h:

https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_txt.h@48 
PS1, Line 48:  * \return Vector of strings. Free with ast_dns_txt_get_strings
ast_dns_txt_free_strings


https://gerrit.asterisk.org/c/asterisk/+/13935/1/main/dns_txt.c 
File main/dns_txt.c:

https://gerrit.asterisk.org/c/asterisk/+/13935/1/main/dns_txt.c@44 
PS1, Line 44: 	 * validate that this confirms to a TXT record. */
conforms


https://gerrit.asterisk.org/c/asterisk/+/13935/1/main/dns_txt.c@56 
PS1, Line 56: 	txt = ast_calloc(1, sizeof(*txt) + size);
If this fails return NULL


https://gerrit.asterisk.org/c/asterisk/+/13935/1/main/dns_txt.c@103 
PS1, Line 103: 		/* We've know the size in advance so this can't fail */
We know



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13935
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie0eca23b8e6f4c7d9846b6013d79099314d90ef5
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 12 Mar 2020 11:17:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200312/5c8f5367/attachment.html>