<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13935">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_internal.h">File include/asterisk/dns_internal.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_internal.h@29">Patch Set #1, Line 29:</a> <code style="font-family:monospace,monospace">/*! \brief For AST_LIST */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Where is AST_LIST used?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_txt.h">File include/asterisk/dns_txt.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13935/1/include/asterisk/dns_txt.h@48">Patch Set #1, Line 48:</a> <code style="font-family:monospace,monospace"> * \return Vector of strings. Free with ast_dns_txt_get_strings</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_dns_txt_free_strings</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13935/1/main/dns_txt.c">File main/dns_txt.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13935/1/main/dns_txt.c@44">Patch Set #1, Line 44:</a> <code style="font-family:monospace,monospace">    * validate that this confirms to a TXT record. */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">conforms</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13935/1/main/dns_txt.c@56">Patch Set #1, Line 56:</a> <code style="font-family:monospace,monospace">  txt = ast_calloc(1, sizeof(*txt) + size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If this fails return NULL</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13935/1/main/dns_txt.c@103">Patch Set #1, Line 103:</a> <code style="font-family:monospace,monospace">                /* We've know the size in advance so this can't fail */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We know</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13935">change 13935</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13935"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie0eca23b8e6f4c7d9846b6013d79099314d90ef5 </div>
<div style="display:none"> Gerrit-Change-Number: 13935 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 12 Mar 2020 11:17:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>