[Asterisk-code-review] res_pjsip_sdp_rtp: don't wait for ICE if not negotiated (asterisk[13])

[Torrey Searle]

Torrey Searle has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/13856 )


Change subject: res_pjsip_sdp_rtp: don't wait for ICE if not negotiated
......................................................................

res_pjsip_sdp_rtp: don't wait for ICE if not negotiated

If ICE support is enabled, but not negotiated.  The rtp->ice
structure is not currently being destroied.  This leads to
res_rtp_asterisk waiting for ICE to complete instead of
immediatly starting the DTLS handshake.  This results in
the call leg having no RTP.

ASTERISK-28769 #close

Change-Id: I17c137546dc9ecfb9583c24dcf4c2ced8bbd7a27
---
M res/res_pjsip_sdp_rtp.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/56/13856/1

diff --git a/res/res_pjsip_sdp_rtp.c b/res/res_pjsip_sdp_rtp.c
index 15245f2..c745baf 100644
--- a/res/res_pjsip_sdp_rtp.c
+++ b/res/res_pjsip_sdp_rtp.c
@@ -531,6 +531,9 @@
 
 	if (!session->endpoint->media.rtp.ice_support || !(ice = ast_rtp_instance_get_ice(session_media->rtp)) ||
 		!session_media->remote_ice || !(candidates = ice->get_local_candidates(session_media->rtp))) {
+		if (ice) {
+			ice->stop(session_media->rtp);
+		}
 		return;
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13856
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I17c137546dc9ecfb9583c24dcf4c2ced8bbd7a27
Gerrit-Change-Number: 13856
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200305/182be529/attachment.html>