<p>Torrey Searle has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13856">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res_pjsip_sdp_rtp: don't wait for ICE if not negotiated<br><br>If ICE support is enabled, but not negotiated.  The rtp->ice<br>structure is not currently being destroied.  This leads to<br>res_rtp_asterisk waiting for ICE to complete instead of<br>immediatly starting the DTLS handshake.  This results in<br>the call leg having no RTP.<br><br>ASTERISK-28769 #close<br><br>Change-Id: I17c137546dc9ecfb9583c24dcf4c2ced8bbd7a27<br>---<br>M res/res_pjsip_sdp_rtp.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/56/13856/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_pjsip_sdp_rtp.c b/res/res_pjsip_sdp_rtp.c</span><br><span>index 15245f2..c745baf 100644</span><br><span>--- a/res/res_pjsip_sdp_rtp.c</span><br><span>+++ b/res/res_pjsip_sdp_rtp.c</span><br><span>@@ -531,6 +531,9 @@</span><br><span> </span><br><span>   if (!session->endpoint->media.rtp.ice_support || !(ice = ast_rtp_instance_get_ice(session_media->rtp)) ||</span><br><span>           !session_media->remote_ice || !(candidates = ice->get_local_candidates(session_media->rtp))) {</span><br><span style="color: hsl(120, 100%, 40%);">+               if (ice) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    ice->stop(session_media->rtp);</span><br><span style="color: hsl(120, 100%, 40%);">+          }</span><br><span>            return;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13856">change 13856</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13856"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I17c137546dc9ecfb9583c24dcf4c2ced8bbd7a27 </div>
<div style="display:none"> Gerrit-Change-Number: 13856 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>