[Asterisk-code-review] Non negotiated rtp frame causes call disconnection when there is a SS... (testsuite[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/13847 )

Change subject: Non negotiated rtp frame causes call disconnection when there is a SSRC change
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/testsuite/+/13847/1/tests/channels/pjsip/non_negotiated_frame_SSRC_change/run-test 
File tests/channels/pjsip/non_negotiated_frame_SSRC_change/run-test:

https://gerrit.asterisk.org/c/testsuite/+/13847/1/tests/channels/pjsip/non_negotiated_frame_SSRC_change/run-test@1 
PS1, Line 1: #!/usr/bin/env python
This needs to be written fully using test-config.yaml instead[1]. The usage of run-test generally only prolongs test execution times, is harder to debug, does not leverage things automatically.

[1] https://github.com/asterisk/testsuite/blob/master/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/test-config.yaml


https://gerrit.asterisk.org/c/testsuite/+/13847/1/tests/channels/pjsip/non_negotiated_frame_SSRC_change/test-config.yaml 
File tests/channels/pjsip/non_negotiated_frame_SSRC_change/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/13847/1/tests/channels/pjsip/non_negotiated_frame_SSRC_change/test-config.yaml@4 
PS1, Line 4:          'When there was a SSRC change, the frame would be marked as a control frame and it would be queued to be written and then leading to a disconnection (ast_channel_softhangup_internal_flag_add).'
This is a long line, it should be manually cut off and placed on a newline



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13847
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: If3e760a7bb94c9bfc1ee24aff7f5fd7a3cbd33ed
Gerrit-Change-Number: 13847
Gerrit-PatchSet: 1
Gerrit-Owner: Paulo Vicentini <paulo.vicentini at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 17:09:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200302/736b2dd0/attachment.html>