<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13847">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13847/1/tests/channels/pjsip/non_negotiated_frame_SSRC_change/run-test">File tests/channels/pjsip/non_negotiated_frame_SSRC_change/run-test:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13847/1/tests/channels/pjsip/non_negotiated_frame_SSRC_change/run-test@1">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">#!/usr/bin/env python</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This needs to be written fully using test-config.yaml instead[1]. The usage of run-test generally only prolongs test execution times, is harder to debug, does not leverage things automatically.</p><p style="white-space: pre-wrap; word-wrap: break-word;">[1] https://github.com/asterisk/testsuite/blob/master/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user/test-config.yaml</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13847/1/tests/channels/pjsip/non_negotiated_frame_SSRC_change/test-config.yaml">File tests/channels/pjsip/non_negotiated_frame_SSRC_change/test-config.yaml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13847/1/tests/channels/pjsip/non_negotiated_frame_SSRC_change/test-config.yaml@4">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace">         'When there was a SSRC change, the frame would be marked as a control frame and it would be queued to be written and then leading to a disconnection (ast_channel_softhangup_internal_flag_add).'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is a long line, it should be manually cut off and placed on a newline</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/13847">change 13847</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/13847"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If3e760a7bb94c9bfc1ee24aff7f5fd7a3cbd33ed </div>
<div style="display:none"> Gerrit-Change-Number: 13847 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Paulo Vicentini <paulo.vicentini@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 02 Mar 2020 17:09:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>