[Asterisk-code-review] res_http_websocket: Add payload masking to the websocket client (asterisk[master])

[Moises Silva]

Moises Silva has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14520 )

Change subject: res_http_websocket: Add payload masking to the websocket client
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 3: Code-Review+1
> 
> > Patch Set 3:
> > 
> > Looks great now, thank you!
> 
> Nickolay, Feel free to add your +1 to the review!
> 
> Moises, Please cherry pick to the 13, 16 and 17 branches.

As expected, the cherry-pick fails in 13 (may be it will in others) given how far advanced master is. I am a gerrit newbie and the Asterisk docs on Gerrit usage say "What do do when a cherry-pick fails, etc.  Coming Soon!" 😊

I'll proceed with the cherry pick regardless, let the build fail and adapt the changes locally. I hope that's acceptable.

https://gerrit.asterisk.org/c/asterisk/+/14520/2/res/res_http_websocket.c 
File res/res_http_websocket.c:

https://gerrit.asterisk.org/c/asterisk/+/14520/2/res/res_http_websocket.c@335 
PS2, Line 335: 	res = ast_iostream_write(session->stream, frame, sizeof(frame));
> Here for server case we shouldn't use sizeof(frame) anymore but 4 bytes since header is just 2. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14520
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id465030f2b1997b83d408933fdbabe01827469ca
Gerrit-Change-Number: 14520
Gerrit-PatchSet: 3
Gerrit-Owner: Moises Silva <moises.silva at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Nickolay V. Shmyrev <nshmyrev at alphacephei.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 17 Jun 2020 07:23:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nickolay V. Shmyrev <nshmyrev at alphacephei.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200617/6b623884/attachment-0001.html>