<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3: Code-Review+1</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Looks great now, thank you!</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Nickolay, Feel free to add your +1 to the review!</p><p style="white-space: pre-wrap; word-wrap: break-word;">Moises, Please cherry pick to the 13, 16 and 17 branches.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">As expected, the cherry-pick fails in 13 (may be it will in others) given how far advanced master is. I am a gerrit newbie and the Asterisk docs on Gerrit usage say "What do do when a cherry-pick fails, etc.  Coming Soon!" 😊</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll proceed with the cherry pick regardless, let the build fail and adapt the changes locally. I hope that's acceptable.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14520">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14520/2/res/res_http_websocket.c">File res/res_http_websocket.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14520/2/res/res_http_websocket.c@335">Patch Set #2, Line 335:</a> <code style="font-family:monospace,monospace"> res = ast_iostream_write(session->stream, frame, sizeof(frame));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Here for server case we shouldn't use sizeof(frame) anymore but 4 bytes since header is just 2. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14520">change 14520</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14520"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id465030f2b1997b83d408933fdbabe01827469ca </div>
<div style="display:none"> Gerrit-Change-Number: 14520 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Moises Silva <moises.silva@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nickolay V. Shmyrev <nshmyrev@alphacephei.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 17 Jun 2020 07:23:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Nickolay V. Shmyrev <nshmyrev@alphacephei.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>