[Asterisk-code-review] res_stir_shaken: Add inbound INVITE support. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14447 )

Change subject: res_stir_shaken: Add inbound INVITE support.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/c/asterisk/+/14447/1/include/asterisk/res_stir_shaken.h 
File include/asterisk/res_stir_shaken.h:

https://gerrit.asterisk.org/c/asterisk/+/14447/1/include/asterisk/res_stir_shaken.h@42 
PS1, Line 42: ast_stir_shaken_payload_algorithm
We should try to use actions in the names...
<object>_<action>_<item>
So ast_stir_shaken_payload_get_algorithm.


https://gerrit.asterisk.org/c/asterisk/+/14447/1/include/asterisk/res_stir_shaken.h@51 
PS1, Line 51: char *ast_stir_shaken_payload_public_key_url(const struct ast_stir_shaken_payload *payload);
Same


https://gerrit.asterisk.org/c/asterisk/+/14447/1/include/asterisk/res_stir_shaken.h@58 
PS1, Line 58: unsigned int ast_stir_shaken_get_signature_timeout(void);
Good here 😊


https://gerrit.asterisk.org/c/asterisk/+/14447/1/res/res_pjsip_stir_shaken.c 
File res/res_pjsip_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/14447/1/res/res_pjsip_stir_shaken.c@280 
PS1, Line 280: 	ast_module_shutdown_ref(AST_MODULE_SELF);
Why do we need to prevent unloading this module?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14447
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I855f857be3d1c63b64812ac35d9ce0534085b913
Gerrit-Change-Number: 14447
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 01 Jun 2020 14:17:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200601/76fc43a2/attachment.html>