<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14447">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14447/1/include/asterisk/res_stir_shaken.h">File include/asterisk/res_stir_shaken.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14447/1/include/asterisk/res_stir_shaken.h@42">Patch Set #1, Line 42:</a> <code style="font-family:monospace,monospace">ast_stir_shaken_payload_algorithm</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We should try to use actions in the names...<br><object>_<action>_<item><br>So ast_stir_shaken_payload_get_algorithm.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14447/1/include/asterisk/res_stir_shaken.h@51">Patch Set #1, Line 51:</a> <code style="font-family:monospace,monospace">char *ast_stir_shaken_payload_public_key_url(const struct ast_stir_shaken_payload *payload);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14447/1/include/asterisk/res_stir_shaken.h@58">Patch Set #1, Line 58:</a> <code style="font-family:monospace,monospace">unsigned int ast_stir_shaken_get_signature_timeout(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Good here 😊</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14447/1/res/res_pjsip_stir_shaken.c">File res/res_pjsip_stir_shaken.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14447/1/res/res_pjsip_stir_shaken.c@280">Patch Set #1, Line 280:</a> <code style="font-family:monospace,monospace">    ast_module_shutdown_ref(AST_MODULE_SELF);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why do we need to prevent unloading this module?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14447">change 14447</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14447"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I855f857be3d1c63b64812ac35d9ce0534085b913 </div>
<div style="display:none"> Gerrit-Change-Number: 14447 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 01 Jun 2020 14:17:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>