[Asterisk-code-review] app_followme: Allow disabling FollowMe prompt (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14696 )

Change subject: app_followme: Allow disabling FollowMe prompt
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

For new features, and improvements that are added to release branches we require some sort of test (Asterisk unit and/or testsuite test). Can this be tested via the Asterisk testsuite? Does it make sense to? I do see at least one test using app_followme in the Testsuite (tests/predial/).

https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c 
File apps/app_followme.c:

https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@965 
PS1, Line 965: 				// if no callee prompt enabled
C++ style comments are not allowed. Please convert to C-style, e.g. /* blah */


https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@970 
PS1, Line 970: 				) { // make sure to perform all actions as if prompt is enabled
Change to C-style comment


https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@973 
PS1, Line 973: 					tmpuser->yn[tmpuser->ynidx++] = 1; // force 1???
Change to C-style comment. Actually this one probably can be removed, or made more descriptive?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14696
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic15a2bac4f16d0fce7a1b5e7b375f9bafee37aa4
Gerrit-Change-Number: 14696
Gerrit-PatchSet: 1
Gerrit-Owner: Dennis <dennis.buteyn at xorcom.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 28 Jul 2020 20:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200728/cc98e2cf/attachment-0001.html>