<p style="white-space: pre-wrap; word-wrap: break-word;">For new features, and improvements that are added to release branches we require some sort of test (Asterisk unit and/or testsuite test). Can this be tested via the Asterisk testsuite? Does it make sense to? I do see at least one test using app_followme in the Testsuite (tests/predial/).</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14696">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c">File apps/app_followme.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@965">Patch Set #1, Line 965:</a> <code style="font-family:monospace,monospace">                          // if no callee prompt enabled</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">C++ style comments are not allowed. Please convert to C-style, e.g. /* blah */</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@970">Patch Set #1, Line 970:</a> <code style="font-family:monospace,monospace">                         ) { // make sure to perform all actions as if prompt is enabled</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Change to C-style comment</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@973">Patch Set #1, Line 973:</a> <code style="font-family:monospace,monospace">                                     tmpuser->yn[tmpuser->ynidx++] = 1; // force 1???</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Change to C-style comment. Actually this one probably can be removed, or made more descriptive?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14696">change 14696</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14696"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Ic15a2bac4f16d0fce7a1b5e7b375f9bafee37aa4 </div>
<div style="display:none"> Gerrit-Change-Number: 14696 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Dennis <dennis.buteyn@xorcom.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Jul 2020 20:30:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>