[Asterisk-code-review] chan_sip: Return 503 if we're out of RTP ports (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13678 )

Change subject: chan_sip: Return 503 if we're out of RTP ports
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13678/1/channels/chan_sip.c 
File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/13678/1/channels/chan_sip.c@19628 
PS1, Line 19628: int reliable
It may be a bit too clever, but I would pass `transmit_response_reliable` or `transmit_response` here as a function pointer. It's self documenting.

Otherwise maybe a quick enum like SIP_SND_RELIABLE/SIP_SEND_UNRELIABLE (or whatever)

Feel free to ignore both of these suggestions.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13678
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I968dcf6c1e30ecddcce397dcda36db727c83ca90
Gerrit-Change-Number: 13678
Gerrit-PatchSet: 1
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 30 Jan 2020 16:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200130/39df0d6f/attachment-0001.html>