<p><a href="https://gerrit.asterisk.org/c/asterisk/+/13678">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13678/1/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13678/1/channels/chan_sip.c@19628">Patch Set #1, Line 19628:</a> <code style="font-family:monospace,monospace">int reliable</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It may be a bit too clever, but I would pass `transmit_response_reliable` or `transmit_response` here as a function pointer. It's self documenting.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Otherwise maybe a quick enum like SIP_SND_RELIABLE/SIP_SEND_UNRELIABLE (or whatever)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Feel free to ignore both of these suggestions.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13678">change 13678</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13678"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I968dcf6c1e30ecddcce397dcda36db727c83ca90 </div>
<div style="display:none"> Gerrit-Change-Number: 13678 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Walter Doekes <walter+asterisk@wjd.nu> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 30 Jan 2020 16:28:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>