[Asterisk-code-review] A dialplan function to change endpoint's configuration on a session (asterisk[13])

[Salah Ahmed]

Salah Ahmed has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13501 )

Change subject: A dialplan function to change endpoint's configuration on a session
......................................................................


Patch Set 4:

(2 comments)

Hi Joshua,

Please guide me if this implementation isn't correct.

Thank You

https://gerrit.asterisk.org/c/asterisk/+/13501/3/channels/pjsip/dialplan_functions.c 
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/c/asterisk/+/13501/3/channels/pjsip/dialplan_functions.c@1332 
PS3, Line 1332: int pjsip_session_endpoint_write(struct ast_channel *chan, const char *cmd, char *data, const char *value)
> The threading for this is not correct. […]
Added a new callback method for serializer.


https://gerrit.asterisk.org/c/asterisk/+/13501/3/channels/pjsip/dialplan_functions.c@1365 
PS3, Line 1365: 	if (ast_sorcery_objectset_apply(ast_sip_get_sorcery(), endpoint, objset)) {
> The endpoint is immutable. It can not be altered here without repercussions. […]
Now we first copy the endpoint and use that one on the session and update the changed endpoint option to that copied endpoint.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13501
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I600d5ac1c6c2b47a7a0da6425aea559f1aa61c7c
Gerrit-Change-Number: 13501
Gerrit-PatchSet: 4
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 07 Jan 2020 13:54:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200107/d2004418/attachment.html>