<p style="white-space: pre-wrap; word-wrap: break-word;">Hi Joshua,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Please guide me if this implementation isn't correct.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thank You</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13501">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13501/3/channels/pjsip/dialplan_functions.c">File channels/pjsip/dialplan_functions.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13501/3/channels/pjsip/dialplan_functions.c@1332">Patch Set #3, Line 1332:</a> <code style="font-family:monospace,monospace">int pjsip_session_endpoint_write(struct ast_channel *chan, const char *cmd, char *data, const char *value)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The threading for this is not correct. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Added a new callback method for serializer.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13501/3/channels/pjsip/dialplan_functions.c@1365">Patch Set #3, Line 1365:</a> <code style="font-family:monospace,monospace">  if (ast_sorcery_objectset_apply(ast_sip_get_sorcery(), endpoint, objset)) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The endpoint is immutable. It can not be altered here without repercussions. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Now we first copy the endpoint and use that one on the session and update the changed endpoint option to that copied endpoint.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13501">change 13501</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13501"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I600d5ac1c6c2b47a7a0da6425aea559f1aa61c7c </div>
<div style="display:none"> Gerrit-Change-Number: 13501 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Salah Ahmed <txrubel@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Jan 2020 13:54:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>