[Asterisk-code-review] Stasis/messaging: tech subscriptions conflict with endpoint subscript... (asterisk[master])

[Jean Aunis - Prescom]

Attention is currently required from: Sean Bright.
Jean Aunis - Prescom has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15301 )

Change subject: Stasis/messaging: tech subscriptions conflict with endpoint subscriptions
......................................................................


Patch Set 1:

(1 comment)

File res/stasis/messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15301/comment/63418274_f0ded834 
PS1, Line 312: 			ast_rwlock_unlock(&tech_subscriptions_lock);
> You don't want to be holding this lock while calling the callback, so you'll have to build a list/ve […]
OK.

Since we should have a maximum of 3 subscriptions: one for TECH_WILDCARD, one for the tech itself, and one for the endpoint, do you think it is valid to use a statically-alloc'd array of 3 subscriptions, instead of a vector ?
This would save a malloc, but arguably it would reduce extensibility in the future.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15301
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9eac4cba5f9e27285a282509395347abc58fc2b8
Gerrit-Change-Number: 15301
Gerrit-PatchSet: 1
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Attention: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 31 Dec 2020 08:12:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201231/0c5a0afd/attachment.html>