[Asterisk-code-review] Stasis/messaging: tech subscriptions conflict with endpoint subscript... (asterisk[master])

[Sean Bright]

Attention is currently required from: Jean Aunis - Prescom.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15301 )

Change subject: Stasis/messaging: tech subscriptions conflict with endpoint subscriptions
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1: 
In addition to the specific comment, please review the coding guidelines. There were some issues I noticed in passing specifically around spacing.

 https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines


File res/stasis/messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15301/comment/b6a4e602_cc4cfabb 
PS1, Line 312: 			ast_rwlock_unlock(&tech_subscriptions_lock);
You don't want to be holding this lock while calling the callback, so you'll have to build a list/vector of endpoints to dispatch messages about and then unlock and then call the callbacks.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15301
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9eac4cba5f9e27285a282509395347abc58fc2b8
Gerrit-Change-Number: 15301
Gerrit-PatchSet: 1
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Attention: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Comment-Date: Wed, 30 Dec 2020 20:57:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201230/1047e08d/attachment.html>