[Asterisk-code-review] chan_pjsip: Incorporate session reference count into transfer_refer(). (asterisk[16])

[Joshua Colp]

Attention is currently required from: Dan Cropp.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15195 )

Change subject: chan_pjsip: Incorporate session reference count into transfer_refer().
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> Since the xfer_client_on_evsub_state() function is a PJPROJECT callback, it is already serialized an […]
I'd have to see an implementation to actually be able to answer that. It may be fine? Ensuring that the reference count is correct, however, would be the problematic part. You can't access session->channel from outside of a serialized task on the session itself, so you can't depend on it, as the pointer can be manipulated. Only your own pointer to a channel would be safe.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15195
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3fd92fd14b4e3844d3d7b0f60fe417a4df5f2435
Gerrit-Change-Number: 15195
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Dan Cropp <dan at amtelco.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 20:31:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dan Cropp <dan at amtelco.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201214/813c1a39/attachment.html>