[Asterisk-code-review] chan_pjsip: Incorporate session reference count into transfer_refer(). (asterisk[16])

[Dan Cropp]

Attention is currently required from: Joshua Colp.
Dan Cropp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15195 )

Change subject: chan_pjsip: Incorporate session reference count into transfer_refer().
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1: 
> Per your question on asterisk-dev, are you still working on this?
Yes, we are still looking at it.

We are working to figure out the subscription serializing because the NOTIFY and a timeout could interrupt each other, with the possibility that the interfering call could delete the subscription while the interrupted call still needs it.


PS1: 
Since the xfer_client_on_evsub_state() function is a PJPROJECT callback, it is already serialized and we're wondering if pushing a new task is appropriate.  Instead, we would prefer to bump the session and channel reference counts appropriately to ensure that those structures are available when needed.  (The serializer used for the callback is not the session serializer, so doesn't protect the session or channel.)

Since the channel/session is only used for a call to ast_queue_control_data() and a couple of debug messages it seems like using reference counts should be adequate.

Would this be an acceptable approach?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15195
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3fd92fd14b4e3844d3d7b0f60fe417a4df5f2435
Gerrit-Change-Number: 15195
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 20:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201214/783fe96f/attachment.html>