[Asterisk-code-review] res_ari: Fix wrong null media for channel play (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15205 )

Change subject: res_ari: Fix wrong null media for channel play
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15205/1/res/res_stasis_playback.c 
File res/res_stasis_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/15205/1/res/res_stasis_playback.c@492 
PS1, Line 492: 		if (media[i] == NULL) {
Should this use ast_strlen_zero instead?


https://gerrit.asterisk.org/c/asterisk/+/15205/1/res/res_stasis_playback.c@493 
PS1, Line 493: 			ast_log(LOG_ERROR, "Invalid media uri. The given media is null. channel: %s\n",
I think this log message should be adjusted to more closely match other error messages, for example:

Attempted to play media on channel '%s' but no media URI was provided



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15205
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6691c640247a51ad15f23e4a203ca8430809bafe
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 1
Gerrit-Owner: Sungtae Kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 03 Dec 2020 13:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201203/3c5a8ef0/attachment.html>