[Asterisk-code-review] res_ari: Fix wrong null media for channel play (asterisk[master])

Sungtae Kim asteriskteam at digium.com
Tue Dec 1 23:29:33 CST 2020


Sungtae Kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15205 )

Change subject: res_ari: Fix wrong null media for channel play
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> `media` appears to be required, so I am not sure why we wouldn't have already returned an error when parsing the request? Seems like we should fail before we ever even get here.

Hi Sean,

I agree with that. Is might be a good idea to fix the mustache's "required" filed handler?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15205
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6691c640247a51ad15f23e4a203ca8430809bafe
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 1
Gerrit-Owner: Sungtae Kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 02 Dec 2020 05:29:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201201/43b283ba/attachment.html>


More information about the asterisk-code-review mailing list