[Asterisk-code-review] app_queue: check for leaking Stasis subscriptions after Redirect() (testsuite[16])

Richard Mudgett asteriskteam at digium.com
Tue Apr 28 07:31:23 CDT 2020


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/14210 )

Change subject: app_queue: check for leaking Stasis subscriptions after Redirect()
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review-1
> 
> (3 comments)
> 
> The concern that comes to mind is the test becoming fragile in the future if we use taskprocessors in other ways, thus having to continue to update and tweak the test condition. Thoughts Richard and Kevin?

Anything that processes Asterisk CLI output is going to be fragile.  The CLI output is not intended to be stable.  It is targeted for human consumption.  The output of "core show taskprocessors" has changed several times as new things are tracked.  The task processor names have changed a few times too.  The "outsess" task processor name series has changed from its original naming as internal organization changed.


-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/14210
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I90451cca574e2fa7d825b4cdc0bab03e331c0e9b
Gerrit-Change-Number: 14210
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 12:31:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200428/49e1b593/attachment-0001.html>


More information about the asterisk-code-review mailing list