[Asterisk-code-review] app_queue: check for leaking Stasis subscriptions after Redirect() (testsuite[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/14210 )

Change subject: app_queue: check for leaking Stasis subscriptions after Redirect()
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

The concern that comes to mind is the test becoming fragile in the future if we use taskprocessors in other ways, thus having to continue to update and tweak the test condition. Thoughts Richard and Kevin?

https://gerrit.asterisk.org/c/testsuite/+/14210/2/lib/python/asterisk/taskprocessor_test_condition.py 
File lib/python/asterisk/taskprocessor_test_condition.py:

https://gerrit.asterisk.org/c/testsuite/+/14210/2/lib/python/asterisk/taskprocessor_test_condition.py@27 
PS2, Line 27:         
There's some extra redness in here.


https://gerrit.asterisk.org/c/testsuite/+/14210/2/tests/apps/queues/redirect/configs/ast1/extensions.conf 
File tests/apps/queues/redirect/configs/ast1/extensions.conf:

https://gerrit.asterisk.org/c/testsuite/+/14210/2/tests/apps/queues/redirect/configs/ast1/extensions.conf@5 
PS2, Line 5:       
Redness


https://gerrit.asterisk.org/c/testsuite/+/14210/2/tests/apps/queues/redirect/test-config.yaml 
File tests/apps/queues/redirect/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/14210/2/tests/apps/queues/redirect/test-config.yaml@7 
PS2, Line 7:         
Redness



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/14210
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I90451cca574e2fa7d825b4cdc0bab03e331c0e9b
Gerrit-Change-Number: 14210
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 09:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200428/e6ca093b/attachment.html>