[Asterisk-code-review] app_queue: track masquerades in app_queue to avoid leaked stasis subs... (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14321 )

Change subject: app_queue: track masquerades in app_queue to avoid leaked stasis subscriptions
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14321/1/apps/app_queue.c 
File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/14321/1/apps/app_queue.c@6460 
PS1, Line 6460: 	const char *old_channel_id, *new_channel_id;
              : 
              : 	old_channel_id = ast_json_string_get(ast_json_object_get(channel_blob->blob, "oldchanneluniqueid"));
The compile is failing with the below:

15:09:05  app_queue.c: In function 'handle_masquerade':
15:09:05  app_queue.c:6460:14: error: variable 'old_channel_id' set but not used [-Werror=unused-but-set-variable]
15:09:05    const char *old_channel_id, *new_channel_id;

As a note, if you pass --enable-dev-mode to the configure (e.g. ,./configure --enable-dev-mode) script when building locally it will help catch these types of errors when compiling locally.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14321
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ifc5f9f9fd70903f3c6e49738d3bc632b085d2df6
Gerrit-Change-Number: 14321
Gerrit-PatchSet: 1
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 20:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200422/4c0c8dd4/attachment.html>