<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14321">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14321/1/apps/app_queue.c">File apps/app_queue.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14321/1/apps/app_queue.c@6460">Patch Set #1, Line 6460:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">        const char *old_channel_id, *new_channel_id;<br><br>        old_channel_id = ast_json_string_get(ast_json_object_get(channel_blob->blob, "oldchanneluniqueid"));<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The compile is failing with the below:</p><p style="white-space: pre-wrap; word-wrap: break-word;">15:09:05  app_queue.c: In function 'handle_masquerade':<br>15:09:05  app_queue.c:6460:14: error: variable 'old_channel_id' set but not used [-Werror=unused-but-set-variable]<br>15:09:05    const char *old_channel_id, *new_channel_id;</p><p style="white-space: pre-wrap; word-wrap: break-word;">As a note, if you pass --enable-dev-mode to the configure (e.g. ,./configure --enable-dev-mode) script when building locally it will help catch these types of errors when compiling locally.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14321">change 14321</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14321"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ifc5f9f9fd70903f3c6e49738d3bc632b085d2df6 </div>
<div style="display:none"> Gerrit-Change-Number: 14321 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 22 Apr 2020 20:16:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>